LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

Can I get a feedback on my code?

Solved!
Go to solution

I'm filling out an array with letters (from A to Z). Please run the code and see the behavior. I want my code to work as it's working now. What do you think about what I'm doing? Is it good or bad?

Feel to criticize. 

0 Kudos
Message 1 of 5
(870 Views)

Bad! Way too much duplicate code and unnecessary complications! You are also indexing outside the valid array later.

Message 2 of 5
(852 Views)

See if this can give you some ideas:

 

altenbach_0-1676307536380.png

 

Message 3 of 5
(843 Views)
Solution
Accepted by topic author GRCK5000

Here's what I would probably do (make sure to learn about the output configuration of the addition. Needs to be U8):

 

altenbach_0-1676308083960.png

 

Message 4 of 5
(835 Views)

Wow. Next time, Thanks Mr. Altenbach. So, now I learned to avoid duplication, I should be using for loop. Thanks!!! You made this very simple. Awesome!!!

0 Kudos
Message 5 of 5
(828 Views)