LabVIEW
verification of my software code for best practice
@altenbach wrote:
@billko wrote:
@altenbach wrote:
If the LEDs are not arranged in a row or column, convert to a cluster with arbitrarily arranged LEDs.I find it convenient to convert the array of Booleans to a cluster so you can label them individually. It makes any wires self-documenting.
Yes, but converting to a cluster is a bit more work, especially if you want the labels to be "in the wire" to later (un-)bundle by name, etc. If you just wire to an indicator with the correct labels, it's of course easier.
Here's how I typically use the "caption" for a plain vertical boolean array (play with LED size and font size to match things up).
I bet that in the amount of time it took you to line up the text with the LEDs, you could've made a cluster. 😉
@billko wrote:
I bet that in the amount of time it took you to line up the text with the LEDs, you could've made a cluster. 😉
Don't underestimate my speed.
- show caption
- move caption to right or left side (text justify right if on caption is on left side)
- enter all lines at once
- Select caption and do ctrl+/- to change font size until things line up.
With a cluster, you need to individually enter text into N separate labels, select that arrangement, etc.
... but yes, I also often use clusters, e.g if each LED should be a different color.... 😄 Of course I might also use an array of color LEDs, now each array element can be a different color. Fancy!! 🙂
@Dushy_11 wrote:
My Main purpose of putting the code here for verification was to fine tune my USB communication part where i am communicating with external device through USB based on my protocol of sending command and receiving data against it. Below are the points on which i wanted expert advice
What VI should I even be looking at? Your project is completely disorganized. I suggest having your main VI be directly under you "MyComputer" and then have folders organizing your VIs into logical groups. And "sub VIs" is not a logical group.
@Dushy_11 wrote:
My Main purpose of putting the code here for verification was to fine tune my USB communication part where i am communicating with external device through USB based on my protocol of sending command and receiving data against it. Below are the points on which i wanted expert advice
[snip]
7. My device is sending data (39 Bytes) at 115200 Baud Rate. I want to run the loop at 50 milliseconds. Right now it is running at 130 ms. It means at every 130 ms, i am sending a command of 7 bytes and in return the device is sending 39 bytes.
Well, according to your Subject: 'verification of my software code for best practice'
As to #7, this might be a factor ...
/Y
Thank you, Sure i am restructuring my project as per your valuable suggestions
And the VI i majorly wanted to go under scrutiny here is "WSP Offline GUI Main.vi" under my project and that too the part/loop where i am communicating with VISA in reading and writing data. I am attaching the screenshot for reference.
No, that's because you're using "Bytes at port", which you shouldn't do. I see you have an unused constant 39 which is what should be used (this might cause problems if the system is ending messages with e.g. \n, in which case you should set a termination character and read 100 chars (which'll break early if a \n appears))
Also, you're reading and writing in parallell which is bad. Better would be to read in the 'don't write'-case
Also, don't use Front panel controls as constants, use constants.
/Y
I can't open the code now, but, Is it a "bytes at port" I see in that huge diagram? And it looks like you are writing and reading in parallel but have some waits that control the flow. Am I correct? Usually you only need Write and then Read with no waits, instead you enable a termination character (or a known number of bytes).
