CLD Car Wash Preparation

[jtgardner]

Would anyone like to comment on my solution to the CLD exam preparation on the car wash?  I would be grateful.

Thanks in advance.

[TiTou]

Hi,

Since I am not CLD my comment have a limited value, but there I go for a short analyse :

as regards documentation :
 - VIs have icones and documentation
 - code is documented
 - but front panel indicator and control don't have tip strip

as regards the coding style :
 - it look quite fine and clear
 - there not even one straight wire... (I bet you use the auto-tool )

as regards functionnality :
 - it look quite fine also
 - when the apps starts all the position indicators were "true", I don't remenber the specifications, but I think they should all be initialized to "false"

By the way, how long did you need to code that ?

Hope this helps

[jtgardner]

HI TiTou,

I appreciate your comments.  Yes I did use the auto-wiring tool.

It took me the whole 4 hours.

BW,

JG

[TiTou]

Hi,

I suspect you first had a look at the example solution given by NI because you code is a bit similar yet simpler.

Anyway well done... if you're able to do that within 4 hours !

[jtgardner]

Hi TiTou

Actually, it was in the LabVIEW Advanced class that I became enamored with the queued state machine.  I think the way I handled the logic was quite different and I was wondering whether someone thought the prox switch logic might be too coupled?

I tried the security system exam and git hosed in VI server.  DIdn't do it in four hours.  Actually there is a great deal to do in four hours.

BW,

JG

[RavensFan]

I think I see one logic flaw with respect to the proximity switches.  You only search for the first true in the cluster/array of proximity switches.  So if the Air proximity switch is on, it is not detected if the underbody switch is on assuming that the car already got through the underbody wash and soap cycles.  You can enter and run through the air dry cycle because only the status of the underbody switch is sent assuming that is the first true.

It would probably be better to send in the status of all 3 switches, have one case structure for each cycle, and a comparison where the status of the switches of interest for the cycle are masked through.  I added my idea to the bottom of your prox logic VI, attached.

Great job on what you have accomplished.

[jtgardner]

Dear RavensFan,

Thanks for the VI.  I am grateful and I like the way you handled the logic with the Case.  I have a further concern about what they might interpret as tight coupling and loose cohesiveness.  As I mentioned, I failed on the Security System for lack of time.  Any advice?

Thank you again.

Best wishes,

JG

[RavensFan]

I'm sorry that I can't offer any advice on the exam.  I've made it through the Labview Intermediate 1 and 2 courses.  But I'm not preparing to take any of the exams or planning to take any more courses right now.

I'm impressed with the organization in your program and that you got the main VI, basic typedefs, and the sub VI's done in 4 hours which seems like a short period of time to me.  I figure a half-hour, 45 minutes, or more of preplanning would be needed to have a good organization and architecture.  I think it would be easy to get yourself coded into a hole that takes even more work and time to get out of if you jump write into coding without the upfront planning.

I just wanted to offer a different way of thinking about that portion of the code that I think makes it a bit more efficient and more expandable.

[jtgardner]

Dear Ravens Fan,

I think you are spot-on.  If you go down the wrong path, I think you are hosed for that exam.  You're not going to get it in four hours.

Also, I have been thinking about your points, and this exam is supposed to be about your coding skills and familiarity with LabVIEW.  The error you spotted in the Prox logic, would have come to the fore in the testing phase of the applicatin development.  In other words, before being released, it would have been caught.

Thank you very much for taking the time to examine the code.  I got what I was looking for, someone to offer something that I didn;t know.  Your example of masking is really excellent: efficient and clear.  I will use this perhpas on the exam but certainly in the future with my code development.  I hope you'll look at the secirity system that i post for comment.

BW,

JG