From Friday, April 19th (11:00 PM CDT) through Saturday, April 20th (2:00 PM CDT), 2024, ni.com will undergo system upgrades that may result in temporary service interruption.

We appreciate your patience as we improve our online experience.

BreakPoint

cancel
Showing results for 
Search instead for 
Did you mean: 

I took a new position as a Manufacturing Engineer

I've been a Test Engineer for the past six years, supporting an electronics manufacturing line.  I jumped on a job opening when one of our Manufacturing Engineers quit this month, and this is one of the projects I've inherited! 😄  Good night.

 

braze.png

Jim
You're entirely bonkers. But I'll tell you a secret. All the best people are. ~ Alice
For he does not know what will happen; So who can tell him when it will occur? Eccl. 8:7

Message 1 of 23
(10,684 Views)
And on top of that the VI is broken. Oh and I couldn't help but notice your password is 314. Fantastic choice having it hard coded and 3 characters long.
0 Kudos
Message 2 of 23
(10,677 Views)

@Hooovahh wrote:
 Oh and I couldn't help but notice your password is 314.

Easy as Pi(e). 😄

 

I guess there is very slight "encryption" for those casually looking at the binary data in the file. At least he did not hardcode it as a string of "314", which would have made the code singificantly simpler. 😉

Message 3 of 23
(10,669 Views)

At least most of the subVIs are clearly labeled.

 

We know exactly where data goes in and where it comes out.

(Of course nobody knows what happens in the orange part. :D)

 

Message 4 of 23
(10,667 Views)

@Hooovahh wrote:
And on top of that the VI is broken. [...]

I don't have IMAQ VIs. 

 

The author of this has made some of the most fantastic equipment in our factory.  I aspire to be the scientist he is, with neater block diagrams.

Jim
You're entirely bonkers. But I'll tell you a secret. All the best people are. ~ Alice
For he does not know what will happen; So who can tell him when it will occur? Eccl. 8:7

Message 5 of 23
(10,656 Views)

And still, not the worst code I've ever seen.

 

For your sake, I hope you're not serious.

0 Kudos
Message 6 of 23
(10,632 Views)

natasftw wrote: 

For your sake, I hope you're not serious.


Code mocking is a required tradition. I am sure that code works just fine. 😄

Message 7 of 23
(10,629 Views)

@altenbach wrote:

@Hooovahh wrote:
 Oh and I couldn't help but notice your password is 314.

Easy as Pi(e). 😄

 

I guess there is very slight "encryption" for those casually looking at the binary data in the file. At least he did not hardcode it as a string of "314", which would have made the code singificantly simpler. 😉


Even better if the password is actually 788 or 204 in decimal representation 😄

---
CLA
0 Kudos
Message 8 of 23
(10,618 Views)

@altenbach wrote:

Code mocking is a required tradition. I am sure that code works just fine. 😄

This made me chuckle.  It's so true though. 

---------------------
Patrick Allen: FunctionalityUnlimited.ca
0 Kudos
Message 9 of 23
(10,597 Views)

@altenbach wrote:

natasftw wrote: 

For your sake, I hope you're not serious.


Code mocking is a required tradition. I am sure that code works just fine. 😄


In keeping with tradition

 

Capture1.PNGCapture1.PNG

Yup- it really is in thereSmiley Very Happy  And the read from file in in the main loop!  (Hey thats a depreciated read from text- how old is this code?)


"Should be" isn't "Is" -Jay
Message 10 of 23
(10,570 Views)