Writing a program with temp

[kangn]

 

  

 

 

   

[daveTW]

Is this a test?

Please express your question.

[paul_a_cardinale]

Why are the wires all zig-zaggy?  Don't you care about the quality of your work?

[billko]

---

@paul_a_cardinale wrote:

Why are the wires all zig-zaggy?  Don't you care about the quality of your work?

---

It's not just for aesthetics, either.  Wires that are unkempt are hard to follow making debugging difficult.  Maybe a wire runs behind a VI but it looks like it's connected.  And it needs to be connected.  Or it gets lost in a rat's nest of wires and you don't know where it is supposed to go.

Spaghetti code is like random indents in a text-based language.  The compiler doesn't care, but if you did this and someone came in looking to kill the person who did this, I'd point to your desk and excuse myself early for lunch so I could have plausible deniability for whatever came next.

[NIquist]

If you want people to look at your code, you need to make it easy.  Do a File > Save For Previous Version... and save it for 2018 (many people use older versions) and then post the VI.

No one is going to look at 10 pictures and try to put your logic together.  😉

[paul_a_cardinale]

---

@billko wrote:

---

@paul_a_cardinale wrote:

Why are the wires all zig-zaggy?  Don't you care about the quality of your work?

---

It's not just for aesthetics, either.  Wires that are unkempt are hard to follow making debugging difficult.  Maybe a wire runs behind a VI but it looks like it's connected.  And it needs to be connected.  Or it gets lost in a rat's nest of wires and you don't know where it is supposed to go.

Spaghetti code is like random indents in a text-based language.  The compiler doesn't care, but if you did this and someone came in looking to kill the person who did this, I'd point to your desk and excuse myself early for lunch so I could have plausible deniability for whatever came next.

---

I'm retired now, but I spent a significant percentage (probably more than half) of my time cleaning up the software messes left behind by others (I referred to myself as a software janitor).  So I have little regard for anyone who makes no attempt to do clean work.

[altenbach]

You did not add any text so we don't even know what your question is. A subject of "writing a program with temp" is not any clearer (%TEMP% folder? Temperature? something else?)

Just glancing at the picture, there is a lot of code smell (it reeks!!!!!).

• Event structures trapped inside inner loops and other structures. No!
• A FOR loop disguised as WHILE loop with a fixed number of iterations known from the start. No!
• Plenty of terminals without labels. No! No! No!
• Many control terminal not connected to anything. No!
• Way too many unnecessary local variables. No!
• Glaring race conditions (e.g. you write to a local variable of "stop 2" and read from a local variable in parallel. Whatever happens first wins! There is a 50% change that you read stale data. No!
• Lots of dupliciate code that can be consolidated
• etc
• etc.

As has been said, attach your VI (saved for previous, 2020 or below) and explain exactly the requirements and how it is supposed to be used.