LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

VI written in Labview 2019 not running in labview 2023

I have a vi written some years ago my a collegue who has since left in Labview 2019, due to enforced updates we are now having to use Labview 2023 and the VI no longer runs, I have fixed some of the error messages that it gave me but I dont understand the rest? Any ideas, I have attached the VI

Download All
0 Kudos
Message 1 of 11
(204 Views)

Can you attach the original LabVIEW 2019 version? (i.e. before you "fixed" anything 😉 )

0 Kudos
Message 2 of 11
(202 Views)

I made minimal changes so far but the "original" working version is attached here

0 Kudos
Message 3 of 11
(196 Views)

@Ian4321 wrote:

I made minimal changes so far but the "original" working version is attached here


"Minimal changes" ??!!

Those block diagrams aren't similar at all.

And they're both ugly.

And the 2nd one is much uglier than the first.

Message 4 of 11
(182 Views)

There is no error in this code, so the problem is probably in the subVIs. Can you attach those too?

(cannot look at the second VI at the moment)

 

Are all drivers correctly installed?

 

Still, there is a lot of "code smell" and many parts can be simplified without change in functionality.

 

  • If autoindexing, there is no need to get the size and wire N of a FOR loop.
  • Appending an element (or 1D array) to a 1D array should use "built array". No need to use insert into array and monitor the size, etc. 
  • SubVIs with inputs all around the icon fail all guidelines. A single cluster input is probably sufficient.
  • Instead of x and y arrays, you can use a single complex array. the xy plot known what to do.
  • There is an =0 primitive, but you can just wire [i] to the case and make one case zero and the other default.
  • This is just a downhill run, requiring entering values in edit mode. A proper state machine would make more sense.
  • No serious programmer uses a stacked sequence anymore.
  • ...
0 Kudos
Message 5 of 11
(176 Views)
0 Kudos
Message 6 of 11
(167 Views)

I was looking for the following two subVIs (found inside the stacked sequence):

 

  • EG-FET IV.vi
  • Keithely 230_reworked-2.vi

 

 

0 Kudos
Message 7 of 11
(164 Views)

Some drivers get installed to the specific year's LabVIEW version; it's probably looking for some files in the wrong place. When you open the original VI in 2023, what errors does it say?

0 Kudos
Message 8 of 11
(131 Views)

@altenbach wrote:

There is no error in this code, so the problem is probably in the subVIs. Can you attach those too?

(cannot look at the second VI at the moment)


When I open "EG-FET IV_2.vi", I get a bad wire:

paul_a_cardinale_0-1760660277538.png

 

0 Kudos
Message 9 of 11
(114 Views)

Well, that's the version they hacked around.

 

Still waiting for the original 2019 dependencies, especially "EG-FET IV.vi" and  "Keithely 230_reworked-2.vi", both called from the 2019 toplevel "EG-FET IV - FET.vi " attached earlier.

 

I guess once we have both "EG-FET IV_2.vi" and "EG-FET IV.vi", we can compare and se what went wrong. 😄

0 Kudos
Message 10 of 11
(90 Views)