LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

Should this be in Example Code Repository

I'm just wondering if this is good enough to be submitted in the examples code repository.

It archives files or folders (including its sub directories) by combining all the raw files into parts, encrypting them using blowfish algorithm and finally compressing each part. 

 

Any suggestions appreciated.

 

Kas

 

0 Kudos
Message 1 of 6
(2,771 Views)

Please attach the code in 2009 version.

-----

The best solution is the one you find it by yourself
0 Kudos
Message 2 of 6
(2,737 Views)

Attached is the 2009 version.

0 Kudos
Message 3 of 6
(2,719 Views)

Hi Kas,

 

This looks good!

 

All in all, you've managed to display good coding practice with controls on the left hand side and data flow leading to indicators on the right hand side of the block diagram.  Your front panel is clear and concise and you have used sub VIs to distinguish between different aspects of your code.  One thing I would say is that you probably want to look into creating a LabVIEW project for your application.

 

Other modifications you may wish to make include the use of the LabVIEW Icon Editor to create informative and exclusive icons for your main and sub VIs.  While you have made good use of sub VIs and the connector pane, you may wish to check which terminals are being used; it is best practice to use the left-most terminals first before moving to the inner terminals. 

 

If I am being particularly picky, I would ensure that labels on the block diagram (e.g. for VI names) do not hide any data wires or span across more than one VI.  Try separating VIs to allow enough space between them so as not to confuse the user.  I would also consider aligning all of your controls on the block diagram.

 

I like the way you have annotated both the front panel and block diagram of your code. Take a look at some of our DAQmx example code in NI Example Finder (go to Help>>Find Examples... and search for DAQmx) for a better idea of how we tend to present our examples.  One thing you will notice is that we do not really use arrows to annotate our front panel user interface:

 

DAQmx Example Code.png

 

I also noticed that the files lose their extension once compressed in this way.  Is there any way you could program the code to retain the file extensions?

 

Finally, have you considered uploading your code on the Community Code Exchange?  I think other LabVIEW users could benefit from seeing this and you may even receive useful tips and ideas yourself.

 

Kind regards

 

 

Marshall B
Applications Engineer
National Instruments UK & Ireland
0 Kudos
Message 4 of 6
(2,687 Views)

Thanks for your reply.

 

The reason why file extensions inside the ZIP are lost is because those files no longer represent the original data. They are just binary files with unique and simple ACII headers so that the Parse VI can later on understand how to put the binary files together again. It is designed this way so that even a 10GB file OR directory can be archived, where the current ZIP compression only goes up to 2GB. Furthemore, each part inside the ZIP file in encrypted.

 

Kas

 

 

 

 

0 Kudos
Message 5 of 6
(2,666 Views)

Hi Kas,

 

That makes sense.

 

In that case, there are only minor points which you would need to look at in order to exhibit best coding practice.

 

Kind regards

Marshall B
Applications Engineer
National Instruments UK & Ireland
0 Kudos
Message 6 of 6
(2,644 Views)