Short run time

[gltfrs]

Hi all,

I have wrote and modified this code. There's no error in the code, but I am having hard time of fixing the run time. It runs only up to maximum of 350 iteration. I wanted to run until I receive a true value; before it gets there it just says PASS which is my true value. But the computation is not true. Below is an attachment of my code. If you have any idea how to fix this please make suggestion.

Thank you in advance

[vt92]

Suggestions:

1.) Get rid of the sequences and use a state machine architecture

2.) Wire the error in/out clusters to shift registers in your loop.

3.) If the computation is not correct,but you are getting a true then you logic is somehow flawed.  Can you explain how the computation is supposed to work?

[crossrulz]

Why do you keep configuring your serial port on closing it?  Initialize it once before your main loop and close it once after the main loop.  Everything inside of the main loop should be reads and writes.

Also, for your stop logic, use the In Range and Coerce function.  It'll save you some room and help avoid stupid logic errors.

[crossrulz]

I went ahead and cleaned up your code so that there is only 1 error path, removed locals, only close the serial port once, and (best of all) removed the sequence structures.  Yes, the VI looks long, but that's fine.  I would highly recommend making subVIs for each of your tasks (what you used to have as sequence steps).  See if this works for you.

[gltfrs]

The code you wrote doesn't work because the write visa out is not connected to anything; and the Visa Read gives error -1073807253. And I used case structure because I wanted the program to compute by precedence.

[crossrulz · Accepted solution]

Ha, silly me.  I forgot to wire up a few of the VISA Resources to the next function.  If you fix those up, it should work fine.  You don't need the sequence structures because the data flow will take care of the order for you.  That's why the error cluster and VISA Resource should be propagated to each function.  The only time you need the sequence structure is for the waits, since there's no error input for them.

[gltfrs]

Your code didn't really worked for me. But I modified the code and your suggestions were very helpful.

Thank you