Getting an existing Excel Reference

[Eric1977]

All,

I'd appreciate someome taking a look at my VI. What the VI does is looks for an existing reference of Excel and if it finds one, it will make that the workbook reference. If it does not find one, a dialog box will open asking the user to brouse to an Excel file. If it finds more than one, it will pull all of the workbooks into a simple listbox for the user to choose which one that they want to use.

This was kinda a quick and dirty little VI (which will be used as a subVI) but I need a second set of eyes to look at it and give me suggestions for improvement.

[ben64]

Some quick comments:

In the OpenDialogBox case (and Addl_XL_WB_Ref_1WB), rebundle the workbooks reference to the references cluster (or close it as in the populate listbox case, note that in this case you could use a shift register on the for loop an rebundle it after)

You could make the cluster a Typedef

In the Wait case it is not intuitive why an OK button should open a dialog box, I expected it to stop the vi.

The timeout case of the event structure is not use, it should be deleted.

Ben64