LabVIEW
Elevator program
It looks to me like the program has a lot bigger problems than the light staying on. How do you go to another floor once in the elevator? When I press a number the door closes but nothing else happens. You really need to consider a better architecture for this. A state machine would be much more appropriate.
I agree. It should go off when the elevator arrives. The bigger problem is that the elevator doesn't work, and with all of the sequences, nested loops, and local variables is likely to be a big problem to get it to work.
@sebastiantc wrote:
Hello, I created an elevator program and I would really like some help with it. I would that the boolean buttons outside every floor could turn off over a certain period of time, like in a real elevator. Right now they function well, but they remain on.
You have way too much code! It is a really bad idea to have loops inside loops inside loops and event structures deeply buried somewhere in the middle.
All you need is one while loop and one case structure, a state enum and a cluster in a shift register that contains all current values (... and no sequence structures!). Each state will manipulate the values and then update all indicators. The only local variables needed are to update your controls at certain times, not for storing state information. Well written code with all functionality could probably fit on a postcard.
Maybe see if there are a couple of elevator examples or similar in the certification discussion forum. This seems like a typical practice exam.
Look at some LabVIEW state machine examples. Also, research using shift registers. You will need these for both the enum and to pass the data from state to state.
The enum is just a way to have enumerate your states. You can find an enum constant on the numeric pallette. I suggest making this into a Type Def. Edit the items to have all of the states that you need. Feed the enum to a case structure. Right click the case structure and add case for every value.
The cluster is just a way to hold data of different type in a single control/indicator/wire. Make a cluster constant on the block diagram and then add a constant of the correct data type for each of your controls/indicators. Be sure to give each of these a title. Then you can use bundle and unbundle by name to read and write values.
Once you have a good architecture resetting the control can be done in a few ways - local variables and value properties are two of the ways.
