Should the reference be closed on read-file error, or not?

[ghighuphu]

Dear users,

when I read a file a reference is created an a should close it, when not needed anymore, should I? Below is a minimalistic example to my next serious question: Should I close the reference on read-file error, or not? Is there any created in the case of "file does not exist"?

 

Cheers,

[mikeporter · Accepted solution]

No, when used in this way, the references created by the file read and write functions do not need to be closed -- thought it would have no negative effect if you did.

Also, you don't want or need the case structure around a reference close function.

Mike...

[ghighuphu]

This was a minimal example and there is some (relative) resource extensive data manipulation (in the CASE structure). That's the reason for the

---

@mikeporter wrote:
Also, you don't want or need the case structure around a reference close function.

---

[crossrulz]

The Read and Write File functions will automatically close the file if you do not wire the reference out to anything.  Given your example, that's what I would do.  But in a general case, always use the File Close if you are doing more than one function with your file.  The Close File will run even if there is an error coming into it.

[CoastalMaineBird]

If you are done with the file, then I would vote for explicitly closing the file.  The performance hit is negligible, but your code will be clearer to read.

[ghighuphu]

---

@crossrulz wrote:

The Read and Write File functions will automatically close the file if you do not wire the reference out to anything.  Given your example, that's what I would do.  But in a general case, always use the File Close if you are doing more than one function with your file.  The Close File will run even if there is an error coming into it.

---

Building on your information, I should use "close file" in both cases. Because once I wire out the reference, it exists and should be closed. Or to put the "close file in front of (outside of) the CASE structure"

Thank you for your suggestions!

[mikeporter · Accepted solution]

...or put the close before the case structure.

Mike...