For loop is taking too muhc time to execute

[RavensFan]

---

@Karan_jasani wrote:

Hi,

Please find attached VI where input array is having default values.

The output is correct but takes around 5 minutes.

---

2.5 minutes for me.

I'm looking forward to see how much Altenbach reduces it.

[billko]

---

@RavensFan wrote:

---

@Karan_jasani wrote:

Hi,

Please find attached VI where input array is having default values.

The output is correct but takes around 5 minutes.

---

2.5 minutes for me.

I'm looking forward to see how much Altenbach reduces it.

---

I'm betting two primitives and an auto-indexed FOR loop.  😉

[crossrulz]

---

@RavensFan wrote:

2.5 minutes for me.

I'm looking forward to see how much Altenbach reduces it.

---

I got it down to 284.9ms...

[altenbach]

---

@crossrulz wrote:
I got it down to 284.9ms...

---

Mine was pretty similar but I have the gut feeling that it can be optimized further. 😉

[crossrulz]

---

@altenbach wrote:

---

@crossrulz wrote:
I got it down to 284.9ms...

---

Mine was pretty similar but I have the gut feeling that it can be optimized further. 😉

---

Yep, I've been playing some more.  Preallocating the array and not reshaping seems to help quite a bit.  My Profile Performance and Memory is showing an average of 103.4ms.  Though, this is starting to look a little messy.

[altenbach · Accepted solution]

Here's my version. I am on an old laptop. Will test on a more powerful machine later.

It would be curious if pre-allocating the output array would make any difference. The compiler should be smart enough to figure out the final size. 😉

(And yes, we only need to mask the lower trace, of course. Not shown)

[GerdW]

(Edited: network problems on my side, couldn't upload images…)

[GerdW · Accepted solution]

My approach:

[altenbach · Accepted solution]

Another version (~33ms)....

Parallelization helps slightly, bringing it down to ~22ms. Probably not worth the extra overhead:

[GerdW]

Loopless: