Event Error List in Labview

[Martin88]

Hi Forum,

I have an application where different Errors, Trigger, Events,.. can happend at the same time I would like to write this Events to a .txt file in the end of the application. Right now I am using the attached vi. 

This vi opens an array and every time an event happend for example ch0_rms_min_exeeded, it gets the timestamp and date and searching for the empty rows delete them and write the event to file.

It works fine until now but as soon I get more events it will get cunfusing as there will be a lot of case structures.

So mabye you have a better idea how to do this.

Thanks 
Martin

[billko]

The case structures are nearly identical, except for the strings at the bottom.  I'm assuming the false case is similarly idenitcal.  In any programming language, repetitive code like this is a prime candidate for a subroutine - or in this case, a subVI.  You should try to make a subVI identical to one of the case structures and make it fit universally for all the other cases.

Striahgten up all your wires.  Don't have them run behind structures so you cannot see where they go.  Don't have wires hiding other wires.    It doesn't affect performance but it does affect readability.  You wouldn't code in a text-based language with no indents or random indents, would you?  In later versions of LabVIEW, there is a "Clean Up Diagram" button on the block diagram tool bar.  It makes some pretty decent guesses at reorganization if your workflow doesn't include a cleanup step (but it really should!)

I can't really say much else without seeing actual code.

[Martin88]

Hi Billko,

thanks for you answer. Yes your are right in a programming language i would not make this, but iam new in Labview so this was my first idea as the events can happend at the same time i dont know how i should set with a case structure. I attached my code mabye you have some ideas. 

thanks 
Martin

[JÞB]

I'd use an array of booleans to index through an array of events True means event happened.  use a conditional tunnel to build an array of events that occured

And clean up that code its unreadable.  You may find the style guide a useful resource to improve your code http://www.ni.com/pdf/manuals/321393d.pdf#labview_style_guide

[billko]

Keeping in mind that I would've probably constructed the error handling totally different, this would be a very rudimentary example of what the subVI could look like.

In addition to the things I mentioned above...

For the same reason the engineers bundled the wires in your car together into trunks, so you should combine related wires into clusters.  It avoids a tangled mess.

Try to make your subVIs conform to the default pattern.  That way all your subVIs line up nicely and makes it easy to read because of it.  (The suggestion above is critical to this one.)

You could really benefit from doing this tutorial.  There are a lot more on the site if you look around a bit.

[billko]

---

@JÞB wrote:

I'd use an array of booleans to index through an array of events True means event happened.  use a conditional tunnel to build an array of events that occured

And clean up that code its unreadable.  You may find the style guide a useful resource to improve your code http://www.ni.com/pdf/manuals/321393d.pdf#labview_style_guide

---

You beat me to it.

[Martin88]

Hi Billko,

thanks that helps a lot I will try it with you vi. I will also clean up my code and break it down to smaller vis:) 

[Martin88]

Hi Billko,

it works great thank you very much. But how i going to make it if i would like to just count the value change (True-False, False-True) because right now if i get an error over one hour i get ther error message continuously i would like to implement this event list like this: ch0_rms_exeeded_start (False-True) when it stopps ch0_rms_exeeded_end (True-False) thank you very much.

Martin