09-11-2012 09:59 AM
Hello all
I have solution for "sprinkler controller".
I would be glad if someone could take a look and give me a feedback.
I want to write more comments, but my english is poor and there are many mistakes in my texts. Do you know, can i have any translater with me in time of exam. Or can i use online translators. It will help my very much.
09-11-2012 01:17 PM
@Manushak wrote:
Hello all
I have solution for "sprinkler controller".
I would be glad if someone could take a look and give me a feedback.
I want to write more comments, but my english is poor and there are many mistakes in my texts. Do you know, can i have any translater with me in time of exam. Or can i use online translators. It will help my very much.
Overall a C- job Some things you did well. Please excuse me for only pointing out the flaws as my time is limited.
You have some bad habits that you need to break;
09-11-2012 04:54 PM
Good afternoon,
I am taking the CLD exam tomorrow morning and wanted to submit my sample exam for review. I was able to finish it in just about 4 hours.
Here is my solution, please provide feedback.
Thanks.
Steven
09-12-2012 03:03 AM
Thank you for replying.
To know about flaws of my work more important for me in this time. I will give more attantion to them.
About timing: In requirements I couldn't understand, that when raining, time will be paused, and then will be continued.
09-28-2012 03:51 AM
Hello all. I have got CLD (85 %).
Thanks all of you for helping with yours remarks and advises.
09-28-2012 08:08 AM
@Manushak wrote:
Hello all. I have got CLD (85 %).
Thanks all of you for helping with yours remarks and advises.
CONGRATULATIONS!
12-02-2012 10:13 AM
Hi,
I have my CLD exam on Friday 7th Dec and have spent this afternoon doing the Boiler sample exam.
I would be greatful for any feedback.
The file is LV2012.
Thanks,
Helen
01-18-2013 02:06 PM - edited 01-18-2013 02:07 PM
All
Could you kindly review my sprinkler code ? I've attached 2 versions. One in LabVIEW 2012 and one in 2011. Each folder should have the PDF document if you need it. Please provide feedbacks 🙂
Thank you very much.
P.S: I need to say that I didn't use time as a constraint on this exam. I wanted to get it all right first and then work on my timing. Thanks again !!
01-30-2013 02:21 PM
Hello,
I did a quick browse through your code.
Here are the things I found at first sight.
Some unnecessary bent wires.
Some constants lack a label. (eg. Enable/Disable command for the Enable Disable VI)
Also the Stop state constant lacks labeling.
Choice for design pattern is not explained.
You should only use "Default if unwired" if you're working with an event structure and even then it is sometimes advised to use a clearly visible constant.W
If you have a disable/enable VI, then please use it for all disabling/enabling. (eg. start button does not use this subVI, the cluster does)
Some clusters on the front panel are missing description and tip strip.
Controls and indicators in subVI's do not seem to have descriptions (or tip strips). They should at least have a description.
One good tip would be to run the VI analyzer on your main and your subVI.
This will directly show certain style/documentation issues.
01-30-2013 02:46 PM
Thank you so much Thierry ! Your feedback is appreciated.
I know, documentation is one of my sore points and I need to improve.
Do you have any inputs on the functionality and style ?