Version Conversion

[tiki12revolt]

Hi,

The following VI is from LV 5.1.1 (I think).

I am currently using LV2010.

I would appreciate help in upconversion.

[smercurio_fc · Accepted solution]

That's an incomplete VI, and a very poorly written one at that. I saw at least 2 race conditions caused by misuse and abuse of local variables. Clearly written by a text programmer.

Attached as 8.2.

[tiki12revolt]

Thanks for your help. I am attempting to adapt someone elses old VIs. If you wouldn't mind, how is it incomplete and poorly written? Is there anything I can do to fix that?

[smercurio_fc]

The whole array indexing is not connected. If the VI was runnable in the original then that indicates that the upconvert did not fully convert the VI.

There are also programming elements which seem to be doing nothing, such as the scan rate being multiplied by 50, but not going anywhere.

As for the poor programming, this has to do with the abuse of local variables. There are clear race conditions when it's intedeterminate whether a read or a write will occur first, and the behavior of the VI will be affected by this.

[tiki12revolt]

Thanks for your help! I pulled these VIs off a Windows 2000 machine which died. I do know that before the machine died the VI did run. 

I will have to investiage the race conditions you mentioned.