optimal structure?

[jorge81]

optimal structure.
I am structuring my project with the following loops and case structures. I am following a good method? are good practices?

[CMW..]

Hey,

try to avoid deep nested structures. Please avoid the usage of a While loop in  a While loop in  a while loops.....

If you open LabVIEW -> welcome window -> create Project

take a look at the state machine template or the other architectures already implemented. I guess this would be a good starting point for a good structure..

Regards,

CMW..

[P@Anand]

Not at all. Please go to the Project templates available in LabVIEW and also search for "Design Patterns" in LabVIEW, you will get some good designs to start with your project. You also have tutorials which will guide in using the design patterns according to your requirement.

[crossrulz]

I would also say you likely want to go with a State Machine.

You also might want to break up some of your code into modules.  For instance, you could have a loop just for controlling your motor with another handling your state machine.

[jorge81]

Thanks for resquest.

All that programming structure is because I'm setting the filling and draining three tanks of fuel controlled SCADA. To control this work the state machine would you use?
The programming is finished and the way I said above and it works fine. But this was only the first test and now I want to make it perfect so that no errors occur.

Regards

[mikeporter]

Yes, this application would be well suited for a state machine. Given the added information you provided -- that there are 3 tanks -- I would start by developing a reentrant VI capable of controlling one tank, and at runtime launch a copy of it for each tank.

The problem with having everything in one big VI is that a problem with one tank could adversely effect all three.

Mike...

[billko]

---

@mikeporter wrote:
Yes, this application would be well suited for a state machine. Given the added information you provided -- that there are 3 tanks -- I would start by developing a reentrant VI capable of controlling one tank, and at runtime launch a copy of it for each tank.

The problem with having everything in one big VI is that a problem with one tank could adversely effect all three.

Mike...

---

For instance, if one tank developed a problem where it got stuck, all the other tanks would never get serviced by the VI... and you can just imagine all sorts of bad things happening because of that...

[jorge81]

Thank you. For the problem of the tanks. Two of the tanks discharge on another. Do not know if this affects. I do not think so. If I try to modify the code as soon as possible. But after all the work done do not know if I will have problems where none now.
A greeting.

[CMW..]

Hey,

So you stick to your original architecture?

"But after all the work done...." -> think about the sunk-cost fallacy and modify your architecture 🙂

mikeporter's idea of making the VI reentrant sounds good and also the statemachine should fit your application.

Who knows which problems will arise;  what happens when you need an additional tank; ...

Regards

CMW...

[jorge81]

After thinking it over and discuss it with my partner if I will modify my structure as a state machine.

Thanks for all your advice.