NI Home
Cart Cart | Help
Hello Events Academic NI Developer Zone Support Solutions Products & Services Contact NI MyNI
You are here: 
NI Home > NI Developer Zone > NI Discussion Forums


Announcements
The NI Idea Exchange is a product feedback forum where NI R&D and users work together to submit ideas, collaborate on their development, and vote for the ones they like best. View all of the NI Idea Exchanges to post an idea or add your opinion on an existing one today!
Matthias_H

Revision of many VIs written by NI (usage of the error cluster)

Status: New
by Member Matthias_H on ‎06-13-2012 04:56 AM

Hello,

 

I'm telling my strudents how they should use the error cluster and how important it is. In subvis no error dialogs should be shown and so on (see topics of LabVIEW Core 1 / Core 2).

 

But many VIs written by NI have been programmed very sloppy.

 

Example: VI "Write into spreadsheet file". The error cluster is not wired to the inputs/outputs and if an error occures, an error dialog would pop up. Here is the block diagram of your V "Write into spreadsheet file"I:

 

spreadsheed_file.PNG

 

Please check all of your VIs and do a revision that we can make well-coded applications where the error handling will work correctly.

 

Regards

Comments
by Trusted Enthusiast on ‎06-13-2012 06:57 AM

We've been screaming for this for years.  There are just a lot of VIs in there that are really old and the priority has not been to clean them up or make them more efficient.  I'll be surpised if this or similar isn't already in the Idea Exchange.  I'm just too lazy right now to do a full search.

by Knight of NI on ‎06-13-2012 10:39 AM

More specifically, these VIs should be deprecated and have newer cleaner versions replacing them in the palettes.

by Active Participant X. on ‎06-13-2012 05:55 PM

Does this ring a bell?

by Trusted Enthusiast on ‎06-13-2012 06:01 PM

Ha, and that's just from April.  How soon we forget...

by Knight of NI on ‎06-14-2012 12:33 AM

I don't think this is the same. The previous idea talks about VIs with error code outputs and how they should be replaced with clusters. This one talks about VIs which have internal error handling (and I would add bad connector panes to that).

by Active Participant X. on ‎06-14-2012 12:09 PM

Agreed. I just meant that this pertains to the same category of sloppy code inherited from way back then. NI should spend one release cycle to clean their act and address all open CARs before adding a new hue of pink to the color palette...

by Trusted Enthusiast on ‎06-19-2012 10:25 AM

X., that is a great idea. I know some people have been complaining that new versions of LabVIEW come out too frequently. Spending one cycle on "house cleaning" might be a very good idea. And please fix some of the really bad code in the example finder. New LabVIEW programmers can pick up some very nasty habbits using a few of the examples that ship with LabVIEW.

by Proven Zealot on ‎06-19-2012 02:52 PM

A general cleaning of VIs to conform to modern style guides is a good idea.  It would be necessary to keep the old clunkers around for a while to avoid breaking legacy code as it is updated, but the "This VI is deprecated; switch to a newer one" message could be added easily.

 

I have considered suggesting turning Forum participants loose on this followed by a review by NI LV R&D, but that might be more work for NI than havnig some interns learn LV best practices by fixing the old stuff.

 

Lynn

by Active Participant shb on ‎06-21-2012 03:13 AM

Totally agree, Matthias H

 

Many VIs from NI would fail in a CLD or CLA Test

by Knight of NI on ‎06-25-2012 12:48 PM

Good suggestion.  An interesting exercise would be to post what was wrong with the example and the improved version.

Latest LabVIEW Idea Exchange Blog Posts
About LabVIEW Idea Exchange

Have a LabVIEW Idea?

  1. Browse by label or search in the LabVIEW Idea Exchange to see if your idea has previously been submitted. If your idea exists be sure to vote for the idea by giving it kudos to indicate your approval!
  2. If your idea has not been submitted click Post New Idea to submit a product idea to the LabVIEW Idea Exchange. Be sure to submit a separate post for each idea.
  3. Watch as the community gives your idea kudos and adds their input.
  4. As NI R&D considers the idea, they will change the idea status.
  5. Give kudos to other ideas that you would like to see in a future version of LabVIEW!
Idea Statuses
Top Kudoed Authors
User Kudos Count
132
85
75
68
68
By using this web site, you accept the Terms of Use for this web site. Please read these Terms of Use carefully before using any part of this site. Please go here for information on ni.com's copyright infringement policy.
My Profile | Privacy | Legal | Contact NI © 2011 National Instruments Corporation. All rights reserved.    |    E-Mail this Page E-Mail this Page