Sprinkle Controller solution for example CLD, would I pass?

[kbrezina]

Hey guys, I'm preparing for my CLD.  

Attached is my solution for the Sprinkler Controller example.  I worked on it in a few sessions, and spent 3-3.5 hours total.  

I am curious to know if you guys think it would pass.

Feel free to hurt my feelings! 

Also, if  you're studying as well, feel free to borrow anything here!

[kbrezina]

Found a bug that caused a problem when any Timing was set to 0.  Fixed.  

[Hooovahh]

I believe your timer is working backwards for the display.  The document states:

"When a zone is being serviced, the following should occur: .... The Timing indicator should display the elapsed time in second"

Yours counts down the remaining time when being serviced.

[Hooovahh]

Also it states

"The controller must load the Zone Setup Array data from a Comma Separated Value (.csv) file when the VI starts."

For some reason yours only loads the CSV after clicking Start.

[kbrezina]

---

@Hooovahh wrote:

Also it states

"The controller must load the Zone Setup Array data from a Comma Separated Value (.csv) file when the VI starts."

For some reason yours only loads the CSV after clicking Start.

---

Thanks for the review, Hooovahh.  

I definitely messed up those two bits.  I think I need to make sure I read a little more clearly next time.