From Friday, April 19th (11:00 PM CDT) through Saturday, April 20th (2:00 PM CDT), 2024, ni.com will undergo system upgrades that may result in temporary service interruption.
We appreciate your patience as we improve our online experience.
From Friday, April 19th (11:00 PM CDT) through Saturday, April 20th (2:00 PM CDT), 2024, ni.com will undergo system upgrades that may result in temporary service interruption.
We appreciate your patience as we improve our online experience.
04-25-2017 08:36 PM
@champ065 wrote:
Hello All,
I have attached my sample exam for the ATM. Any feedback you all can provide is greatly appreciated.
I think you forgot to wire up the timeout. I know this was just an oversight because you have the code in there, you've described what happens there, and it works if I wire 10000 to the terminal.
Other than that, you have lots of unnecessarily bent wires, and there is at least one case of backwards-running wires.
I believe the documentation is adequate and all the VIs have icons, including the main VI. I think the hardest thing for me to remember was to give the main VI an icon!
This project feels like it was developed by a LabVIEW programmer for whom the CLD title will be just a formality.
04-26-2017 09:26 AM
Hey there champ!
I think Bill said it well- so I'm going to get "Super Picky" and knock a few bad habits out of you that you picked up programming in a Text language and have no real good use in LabVIEW.
I'll start with the obvious- and, let us play a game of "What is Wrong here?" Take a look at thisFind 5 things wrong in that picture
04-26-2017 09:53 AM
Is it the "_ctl.ctl"? I know it's a hard habit. It doesn't feel right if I don't but I can work on it.
04-26-2017 09:54 AM
@champ065 wrote:
Is it the "_ctl.ctl"? I know it's a hard habit. It doesn't feel right if I don't but I can work on it.
The name is one - find 4 more
04-26-2017 11:13 AM
Part of the second array element is cut off? Other then that I don't see the other two.
04-26-2017 11:23 AM
1. no description
2. "silly_text_weenie_name.name" work on that OK?
3 Saved MAXIMIZED! Do you really miss Windows 3.1 that much?
4. Default Icon
5. "Wlecome" (Are you SURE you are a txt programmer?)
04-28-2017 07:57 AM
You did warn that is was picky. Thanks for the comments and feedback!
04-28-2017 08:12 AM
Hello All,
I have attached my sample exam for the Car Wash. Any feedback you all can provide is greatly appreciated.
04-28-2017 10:38 AM
Hi Champ,
Functionally it seemed quite good. I don't know all of the requirements, but playing around with it, it seemed like it did what it is supposed to.
I'm pretty sure you would lose points for not wiring the error wire through your SubVIs (like your main car wash control). They also like if your SubVI functionality is wrapped in a case structure to handle errors. Doing nothing and passing the error though is acceptable in case of an error.
I noticed at least one of your typedefs had the default icon, make sure to at least put text in the icon.
I think your tip strips are fine, but I think it is more natural to write them in the second person. For example "Click here to select car wash options." Or "Time left in the current step". Things like that.
I'd consider the error wires a major offense, but the other stuff is just nit picky. Good job!
05-07-2017 02:00 AM
Hi everyone,
I took a shot at the Car Wash sample exam and was hoping someone could take a look. It took me a couple of minutes under the 4 hour limit but I didn't complete it all in one sitting - I'm guessing that probably means that I was a bit slow, since although I tried not to 'cheat' and think about it when my timer was off, I probably did a little.
The specifications are included in the zip file for anyone who doesn't already have them.
Some additional questions:
Thanks!