Please review my solution!

[Rajesh_Nair]

Hello All,

I am planning to attend the CLD exam next week. I am practicing some of sample questions. I solved the ATM question.

Kindly please review and let me know the feedback. Attaching the code in both 2014 and 2010 version along with question.

Thank You!

Regards,

Rajesh Nair

[JÞB]

Overall I've seen worse but, you do have a major problem as I se it from looking at your code.

You FORGOT the USER.  Seriously, the user is key.  Tip Strips and Discriptions on EVERY user control or indicator is a must.  Postition the FP so user controls are visable is a must.

I'm not "in love" with your queue handler but could se it on a larger project with a generic queue data type and a priority boolean.  overkill for a CLD exam you only get 4 hours and yo need to document those controls and indicators.

Type defs-  All have default icons (Break that habit now or you'll find something like this someday and be sorry)

There are a few developers I'd be tempted to shoot.  It is a point on code reviews around here now.

Wired terminals not on root block diagram will get you dinged.  do a search i've said it before.

[Rajesh_Nair]

Hello Jeff,

Thanks for your valuable feedback.

I have gone through your post.

http://forums.ni.com/t5/LabVIEW/Community-Nugget-Wired-Terminals-in-Subdiagrams-Clearing-up-the/td-p...

I got your point. Thanks a lot!

-Rajesh

[Rajesh_Nair]

Hello Jeff,

Got the CLD. Thanks Jeff for your help!