Please Review my sprinkler sample exam using PC design.

[LV_COder]

Hi All,

Please Review my sprinkler sample exam using PC design.

I would like request all of you please provide useful feedback for my CLD exam.

Thanks in advance.

Hemant Chourasia

[LV_COder]

Can any body please review my coding and provide some useful feedback.

Hemant

[Jacobson-ni]

Can you try posting it again? I got an error trying to extract the files.

[LV_COder]

I have also checked, not able to open. Error Reporting

Thanks for your info.

Please see the new attached file below.

Hemant

[PalanivelThiruvenkadam]

1.Wire bendings needs to be corrected as a whole looks good but in few areas needs to be corrected.

2.As 2 Loops are handled names can be provided separately for readability

3.In the Execution Loop (State-> Setup Constant is enabled with name as disabled)

4.Assume my initial value for pressure is 70 and i start then also i Low pressure message is displayed

5.Hope Wait until can be used instead of Wait.

[Jacobson-ni]

The biggest thing I noticed and think you would get a lot of points off for is your documentation. I think the functionality and style are okay (you should really be using a project) but you don't have a single label in your main VI which is a lot of easy points on this exam.

[LV_COder]

Thanks Palanivel for such a useful feedback.

When i will do other sample exam, i will keep your suggestion in mind.

Hemant

[LV_COder]

Thanks Matt.

I will do the proper documentation in the comming perparation.

Do you have any other feedback apart from the documentation?/

Hemant

[JÞB]

---

@Jacobson-ni wrote:

The biggest thing I noticed and think you would get a lot of points off for is your documentation. I think the functionality and style are okay (you should really be using a project) but you don't have a single label in your main VI which is a lot of easy points on this exam.

---

Current instructions REQUIRE the use of the *.lvproj provided with the exam materials in order to even be graded.  Read that simply as "If you don't use a project you won't get a grade hence: you cannot recieve a passing grade" Grade=NaN.

[Jacobson-ni]

Good to know Jeff. I figured as much but didn't read the rules carefully enough to know that it was that required.