Certification
CLD Solution for Review
Looks pretty clean, but I have not looked at it in detail.
Here are a few notes:
- Isn't this supposed to be inside a project?
- I hate it when diagrams are maximized to the screen (main VI and file I/O vi)
- You have an existing log file and if I run the VI, new data gets appended. The problem is that the existing entries have a comma as decimal seperators, while the new entries (run in the US) have a decimal point. This could confuse a program that later might analyze the logs. You should decide on a wordwide format.
- To blink the pilot, you can create a direct property node for the button inside the cluster (right-click button on the front panel...create....property node. see image below). No need to get all control references and index out one. (even if you get all the boiler control references, that only needs to be done once outside the loop and not every time it is needed.
- As has been said by jeff above, terminals of subVIs should be on the toplevel diagram, and not buried inside case structures.
- In the file I/O subVI (open file case), you only handle error 7. Shouldn't you handle all errors somehow? For example if the file is "read only", you would get error 8.
- It would seem more easy to format "event" and "event data" into a single string in the main VI. Now you only need one feedback node to see if anything changed. The combination of strings and numerics can easily be done with single formatting statements.
- ...
