07-20-2012 08:41 PM
You're missing the Menu.ctl file from your solution.
I STRONGLY recommend bundling your files into a project file. It looks like you just copy/pasted from a preexisting solution front panel?
I was able to open it by pointing to a solution I have on my local drive, but most reviewers here won't bother (and obviously they wouldn't bother for the actual test).
Lots and lots of spelling mistakes in the ATM messages... running VI Analyzer will point these out to you. Tons and tons of wire bends, and some object overlap... you'll lose points.
"Fast Cash" is non-functional.
You have a while loop in "Read_write file" but it has no purpose? If you wanted to create an Action Engine, you'll need to use a shift register with the loop. Otherwise, get rid of the loop.
Enums and clusters should all be typedefs.
You have a case structure for many of the Boolean Value Change events, so they only trigger if "NewVal = TRUE." This is unnecessary and adds a lot of nesting/complexity. If you're worried about the state of the booleans, set them on startup.
No VI Documentation for your sub-VIs, so you'd definitely lose points there.
Overall, it's almost completely functional, so that's good. Your use of an event-based state machine is a clean architecture. But you will definitely lose a lot of style and documentation points.